lucy/slstatus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix buffer overflow in battery state parsing

Browse Source 
"Not charging" is 12 characters; %12[a-zA-Z ] reads up to 12 chars
plus a NUL terminator (13 bytes) into a 12-byte buffer. Increase
state buffer to 13 in both battery_state and battery_remaining.
This commit is contained in:
drkhsh 2026-02-12 22:52:21 +01:00
parent 4f61bbbd8e
commit 98769dfed7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
components/battery.c
View File

@ -62,7 +62,7 @@
{ "Not charging", "o" }, { "Not charging", "o" },
}; };
size_t i; size_t i;
char path[PATH_MAX], state[12]; char path[PATH_MAX], state[13];
if (esnprintf(path, sizeof(path), POWER_SUPPLY_STATUS, bat) < 0) if (esnprintf(path, sizeof(path), POWER_SUPPLY_STATUS, bat) < 0)
return NULL; return NULL;
@ -81,7 +81,7 @@
{ {
uintmax_t charge_now, current_now, m, h; uintmax_t charge_now, current_now, m, h;
double timeleft; double timeleft;
char path[PATH_MAX], state[12]; char path[PATH_MAX], state[13];
if (esnprintf(path, sizeof(path), POWER_SUPPLY_STATUS, bat) < 0) if (esnprintf(path, sizeof(path), POWER_SUPPLY_STATUS, bat) < 0)
return NULL; return NULL;