add patched defaults

more overflow fix in getatomprop()
commit 244fa852 (and a9aa0d8) tried to fix overflow by checking the number of items returned. however this is not sufficient since the format may be lower than 32 bits. to reproduce the crash, i used the reproducer given in commit 244fa85 but changed the XChangeProperty line to the following to set the property to a 1 element 16 bit item: short si = 1; XChangeProperty(d, w, net_wm_state, XA_ATOM, 16, PropModeReplace, (unsigned char *)&si, 1); this client reliably crashes dwm under ASAN since dwm is trying to read a 32 bit value from a 16 bit one. fix it by checking for format == 32 as well. also change the access type from Atom to long, on my machine Atom is typedef-ed to long already but that may not be true everywere. the XGetWindowProperty manpage says format == 32 is returned as `long` so use `long` directly. (N.B: it also might be worth checking if the returned type is XA_ATOM as well, but i wasn't able to cause any crashes by setting different types so i'm leaving it out for now.)
2026-02-26 11:53:01 +01:00 · 2026-02-20 15:31:29 +01:00 · 2026-02-20 15:31:28 +01:00 · 2026-02-13 10:16:08 +01:00 · 2026-01-30 11:18:38 +01:00 · 2026-01-16 14:13:51 +01:00
13 changed files with 1614 additions and 77 deletions
--- a/2
+++ b/2
@ -1,5 +1,6 @@
 MIT/X Consortium License
 © 2010-2026 Hiltjo Posthuma <hiltjo@codemadness.org>
 © 2006-2019 Anselm R Garbe <anselm@garbe.ca>
 © 2006-2009 Jukka Salmi <jukka at salmi dot ch>
 © 2006-2007 Sander van Dijk <a dot h dot vandijk at gmail dot com>
@ -11,7 +12,6 @@ MIT/X Consortium License
 © 2008 Martin Hurton <martin dot hurton at gmail dot com>
 © 2008 Neale Pickett <neale dot woozle dot org>
 © 2009 Mate Nagy <mnagy at port70 dot net>
 © 2010-2016 Hiltjo Posthuma <hiltjo@codemadness.org>
 © 2010-2012 Connor Lane Smith <cls@lubutu.com>
 © 2011 Christoph Lohmann <20h@r-36.net>
 © 2015-2016 Quentin Rameau <quinq@fifth.space>
--- a/config.def.h
+++ b/config.def.h
@ -3,6 +3,16 @@
 /* appearance */
 static const unsigned int borderpx  = 1;        /* border pixel of windows */
 static const unsigned int snap      = 32;       /* snap pixel */
 static const unsigned int systraypinning = 0;   /* 0: sloppy systray follows selected monitor, >0: pin systray to monitor X */
 static const unsigned int systrayonleft = 0;    /* 0: systray in the right corner, >0: systray on left of status text */
 static const unsigned int systrayspacing = 2;   /* systray spacing */
 static const int systraypinningfailfirst = 1;   /* 1: if pinning fails, display systray on the first monitor, False: display systray on the last monitor*/
 static const int showsystray        = 1;        /* 0 means no systray */
 static const unsigned int gappih    = 20;       /* horiz inner gap between windows */
 static const unsigned int gappiv    = 10;       /* vert inner gap between windows */
 static const unsigned int gappoh    = 10;       /* horiz outer gap between windows and screen edge */
 static const unsigned int gappov    = 30;       /* vert outer gap between windows and screen edge */
 static       int smartgaps          = 0;        /* 1 means no outer gap when there is only one window */
 static const int showbar            = 1;        /* 0 means no bar */
 static const int topbar             = 1;        /* 0 means bottom bar */
 static const char *fonts[]          = { "monospace:size=10" };
@ -38,11 +48,26 @@ static const int resizehints = 1;    /* 1 means respect size hints in tiled resi
 static const int lockfullscreen = 1; /* 1 will force focus on the fullscreen window */
 static const int refreshrate = 120;  /* refresh rate (per second) for client move/resize */
 #define FORCE_VSPLIT 1  /* nrowgrid layout: force two clients to always split vertically */
 #include "vanitygaps.c"
 static const Layout layouts[] = {
 	/* symbol     arrange function */
 	{ "[]=",      tile },    /* first entry is default */
 	{ "><>",      NULL },    /* no layout function means floating behavior */
 	{ "[M]",      monocle },
 	{ "[@]",      spiral },
 	{ "[\\]",     dwindle },
 	{ "H[]",      deck },
 	{ "TTT",      bstack },
 	{ "===",      bstackhoriz },
 	{ "HHH",      grid },
 	{ "###",      nrowgrid },
 	{ "---",      horizgrid },
 	{ ":::",      gaplessgrid },
 	{ "|M|",      centeredmaster },
 	{ ">M>",      centeredfloatingmaster },
 	{ "><>",      NULL },    /* no layout function means floating behavior */
 	{ NULL,       NULL },
 };
 /* key definitions */
@ -72,7 +97,26 @@ static const Key keys[] = {
 	{ MODKEY,                       XK_d,      incnmaster,     {.i = -1 } },
 	{ MODKEY,                       XK_h,      setmfact,       {.f = -0.05} },
 	{ MODKEY,                       XK_l,      setmfact,       {.f = +0.05} },
 	{ MODKEY|ShiftMask,             XK_h,      setcfact,       {.f = +0.25} },
 	{ MODKEY|ShiftMask,             XK_l,      setcfact,       {.f = -0.25} },
 	{ MODKEY|ShiftMask,             XK_o,      setcfact,       {.f =  0.00} },
 	{ MODKEY,                       XK_Return, zoom,           {0} },
 	{ MODKEY|Mod4Mask,              XK_u,      incrgaps,       {.i = +1 } },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_u,      incrgaps,       {.i = -1 } },
 	{ MODKEY|Mod4Mask,              XK_i,      incrigaps,      {.i = +1 } },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_i,      incrigaps,      {.i = -1 } },
 	{ MODKEY|Mod4Mask,              XK_o,      incrogaps,      {.i = +1 } },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_o,      incrogaps,      {.i = -1 } },
 	{ MODKEY|Mod4Mask,              XK_6,      incrihgaps,     {.i = +1 } },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_6,      incrihgaps,     {.i = -1 } },
 	{ MODKEY|Mod4Mask,              XK_7,      incrivgaps,     {.i = +1 } },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_7,      incrivgaps,     {.i = -1 } },
 	{ MODKEY|Mod4Mask,              XK_8,      incrohgaps,     {.i = +1 } },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_8,      incrohgaps,     {.i = -1 } },
 	{ MODKEY|Mod4Mask,              XK_9,      incrovgaps,     {.i = +1 } },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_9,      incrovgaps,     {.i = -1 } },
 	{ MODKEY|Mod4Mask,              XK_0,      togglegaps,     {0} },
 	{ MODKEY|Mod4Mask|ShiftMask,    XK_0,      defaultgaps,    {0} },
 	{ MODKEY,                       XK_Tab,    view,           {0} },
 	{ MODKEY|ShiftMask,             XK_c,      killclient,     {0} },
 	{ MODKEY,                       XK_t,      setlayout,      {.v = &layouts[0]} },
@ -102,8 +146,8 @@ static const Key keys[] = {
 /* click can be ClkTagBar, ClkLtSymbol, ClkStatusText, ClkWinTitle, ClkClientWin, or ClkRootWin */
 static const Button buttons[] = {
 	/* click                event mask      button          function        argument */
-	{ ClkLtSymbol,          0,              Button1,        setlayout,      {0} },
+	{ ClkTagBar,            MODKEY,         Button1,        tag,            {0} },
-	{ ClkLtSymbol,          0,              Button3,        setlayout,      {.v = &layouts[2]} },
+	{ ClkTagBar,            MODKEY,         Button3,        toggletag,      {0} },
 	{ ClkWinTitle,          0,              Button2,        zoom,           {0} },
 	{ ClkStatusText,        0,              Button2,        spawn,          {.v = termcmd } },
 	{ ClkClientWin,         MODKEY,         Button1,        movemouse,      {0} },
--- a/config.h
+++ b/config.h
@ -0,0 +1,147 @@
 /* See LICENSE file for copyright and license details. */
 #include <X11/XF86keysym.h>
 /* appearance */
 static const unsigned int borderpx = 2;       /* border pixel of windows */
 static const unsigned int snap = 32;          /* snap pixel */
 static const unsigned int systraypinning = 0; /* 0: sloppy systray follows selected monitor, >0: pin systray to monitor X */
 static const unsigned int systrayonleft = 0;  /* 0: systray in the right corner, >0: systray on left of status text */
 static const unsigned int systrayspacing = 2; /* systray spacing */
 static const int systraypinningfailfirst = 1; /* 1: if pinning fails, display systray on the first monitor, False: display systray on the last monitor*/
 static const int showsystray = 1;             /* 0 means no systray */
 static const unsigned int gappih = 10;        /* horiz inner gap between windows */
 static const unsigned int gappiv = 10;        /* vert inner gap between windows */
 static const unsigned int gappoh = 10;        /* horiz outer gap between windows and screen edge */
 static const unsigned int gappov = 10;        /* vert outer gap between windows and screen edge */
 static int smartgaps = 0;                     /* 1 means no outer gap when there is only one window */
 static const int showbar = 1;                 /* 0 means no bar */
 static const int topbar = 1;                  /* 0 means bottom bar */
 static const char *fonts[] = {"FiraCode Nerd Font Mono:size=10"};
 static const char dmenufont[] = "FiraCode Nerd Font Mono:size=10";
 static const char col_gray1[] = "#222222";
 static const char col_gray2[] = "#444444";
 static const char col_gray3[] = "#bbbbbb";
 static const char col_gray4[] = "#eeeeee";
 static const char col_cyan[] = "#aaaaff";
 static const char *colors[][3] = {
    /*               fg         bg         border   */
    [SchemeNorm] = {col_gray3, col_gray1, col_gray2},
    [SchemeSel] = {col_gray1, col_cyan, col_cyan},
 };
 /* tagging */
 static const char *tags[] = {"1", "2", "3", "4", "5", "6", "7", "8", "9"};
 static const Rule rules[] = {
    /* xprop(1):
     *	WM_CLASS(STRING) = instance, class
     *	WM_NAME(STRING) = title
     */
    /* class      instance    title       tags mask     isfloating   monitor */
    {"Gimp", NULL, NULL, 0, 1, -1},
    {"Firefox", NULL, NULL, 1 << 8, 0, -1},
 };
 /* layout(s) */
 static const float mfact = 0.55;     /* factor of master area size [0.05..0.95] */
 static const int nmaster = 1;        /* number of clients in master area */
 static const int resizehints = 1;    /* 1 means respect size hints in tiled resizals */
 static const int lockfullscreen = 1; /* 1 will force focus on the fullscreen window */
 static const int refreshrate = 120;  /* refresh rate (per second) for client move/resize */
 #define FORCE_VSPLIT 1 /* nrowgrid layout: force two clients to always split vertically */
 #include "vanitygaps.c"
 static const Layout layouts[] = {
    /* symbol     arrange function */
    {"[]=", tile}, /* first entry is default */
    {"[M]", monocle}, {"[@]", spiral}, {"[\\]", dwindle}, {"H[]", deck}, {"TTT", bstack}, {"===", bstackhoriz}, {"HHH", grid}, {"###", nrowgrid}, {"---", horizgrid}, {":::", gaplessgrid}, {"|M|", centeredmaster}, {">M>", centeredfloatingmaster},
    {"><>", NULL}, /* no layout function means floating behavior */
    {NULL, NULL},
 };
 /* key definitions */
 #define MODKEY Mod4Mask
 #define TAGKEYS(KEY, TAG) {MODKEY, KEY, view, {.ui = 1 << TAG}}, {MODKEY | ControlMask, KEY, toggleview, {.ui = 1 << TAG}}, {MODKEY | ShiftMask, KEY, tag, {.ui = 1 << TAG}}, {MODKEY | ControlMask | ShiftMask, KEY, toggletag, {.ui = 1 << TAG}},
 /* helper for spawning shell commands in the pre dwm-5.0 fashion */
 #define SHCMD(cmd)                                                                                                                                                                                                                                                                                         \
        {                                                                                                                                                                                                                                                                                                  \
                .v = (const char *[]) { "/bin/sh", "-c", cmd, NULL }                                                                                                                                                                                                                                       \
        }
 /* commands */
 static char dmenumon[2] = "0"; /* component of dmenucmd, manipulated in spawn() */
 static const char *dmenucmd[] = {"dmenu_run", "-m", dmenumon, "-fn", dmenufont, "-nb", col_gray1, "-nf", col_gray3, "-sb", col_cyan, "-sf", col_gray2, NULL};
 static const char *termcmd[] = {"st", NULL};
 static const char *up_vol[] = {"pactl", "set-sink-volume", "@DEFAULT_SINK@", "+10%", NULL};
 static const char *down_vol[] = {"pactl", "set-sink-volume", "@DEFAULT_SINK@", "-10%", NULL};
 static const char *mute_vol[] = {"pactl", "set-sink-mute", "@DEFAULT_SINK@", "toggle", NULL};
 static const char *brighter[] = {"brightnessctl", "set", "10%+", NULL};
 static const char *dimmer[] = {"brightnessctl", "set", "10%-", NULL};
 static const Key keys[] = {
    /* modifier                     key        function        argument */
    {MODKEY, XK_p, spawn, {.v = dmenucmd}},
    {MODKEY, XK_Return, spawn, {.v = termcmd}},
    {MODKEY, XK_b, togglebar, {0}},
    {MODKEY, XK_j, focusstack, {.i = +1}},
    {MODKEY, XK_k, focusstack, {.i = -1}},
    {MODKEY, XK_i, incnmaster, {.i = +1}},
    {MODKEY, XK_d, incnmaster, {.i = -1}},
    {MODKEY, XK_h, setmfact, {.f = -0.05}},
    {MODKEY, XK_l, setmfact, {.f = +0.05}},
    {MODKEY | ShiftMask, XK_h, setcfact, {.f = +0.25}},
    {MODKEY | ShiftMask, XK_l, setcfact, {.f = -0.25}},
    {MODKEY | ShiftMask, XK_o, setcfact, {.f = 0.00}},
    {MODKEY | ShiftMask, XK_Return, zoom, {0}},
    {MODKEY | Mod4Mask, XK_u, incrgaps, {.i = +1}},
    {MODKEY | Mod4Mask, XK_i, incrigaps, {.i = +1}},
    {MODKEY | Mod4Mask, XK_o, incrogaps, {.i = +1}},
    {MODKEY | Mod4Mask, XK_6, incrihgaps, {.i = +1}},
    {MODKEY | Mod4Mask, XK_7, incrivgaps, {.i = +1}},
    {MODKEY | Mod4Mask, XK_8, incrohgaps, {.i = +1}},
    {MODKEY | Mod4Mask, XK_9, incrovgaps, {.i = +1}},
    {MODKEY | Mod4Mask, XK_0, togglegaps, {0}},
    {MODKEY, XK_Tab, view, {0}},
    {MODKEY, XK_q, killclient, {0}},
    {MODKEY, XK_t, setlayout, {.v = &layouts[0]}},
    {MODKEY, XK_f, setlayout, {.v = &layouts[1]}},
    {MODKEY, XK_m, setlayout, {.v = &layouts[2]}},
    {MODKEY, XK_space, setlayout, {0}},
    {MODKEY | ShiftMask, XK_space, togglefloating, {0}},
    {MODKEY, XK_0, view, {.ui = ~0}},
    {MODKEY | ShiftMask, XK_0, tag, {.ui = ~0}},
    {MODKEY, XK_comma, focusmon, {.i = -1}},
    {MODKEY, XK_period, focusmon, {.i = +1}},
    {MODKEY | ShiftMask, XK_comma, tagmon, {.i = -1}},
    {MODKEY | ShiftMask, XK_period, tagmon, {.i = +1}},
    TAGKEYS(XK_1, 0) TAGKEYS(XK_2, 1) TAGKEYS(XK_3, 2) TAGKEYS(XK_4, 3) TAGKEYS(XK_5, 4) TAGKEYS(XK_6, 5) TAGKEYS(XK_7, 6) TAGKEYS(XK_8, 7) TAGKEYS(XK_9, 8){MODKEY | ShiftMask, XK_q, quit, {0}},
    // screenshot and multimedia keys
    {Mod1Mask | ShiftMask, XK_s, spawn, SHCMD("shotgun -s - | xclip -t 'image/png' -selection clipboard")},
    {Mod4Mask | ShiftMask, XK_s, spawn, SHCMD("shotgun -g $(hacksaw) - | xclip -t 'image/png' -selection clipboard")},
    {0, XF86XK_AudioMute, spawn, {.v = mute_vol}},
    {0, XF86XK_AudioLowerVolume, spawn, {.v = down_vol}},
    {0, XF86XK_AudioRaiseVolume, spawn, {.v = up_vol}},
    {0, XF86XK_MonBrightnessDown, spawn, {.v = dimmer}},
    {0, XF86XK_MonBrightnessUp, spawn, {.v = brighter}},
 };
 /* button definitions */
 /* click can be ClkTagBar, ClkLtSymbol, ClkStatusText, ClkWinTitle, ClkClientWin, or ClkRootWin */
 static const Button buttons[] = {
    /* click                event mask      button          function        argument */
    {ClkLtSymbol, 0, Button1, setlayout, {0}},
    {ClkLtSymbol, 0, Button3, setlayout, {.v = &layouts[2]}},
    {ClkWinTitle, 0, Button2, zoom, {0}},
    {ClkStatusText, 0, Button2, spawn, {.v = termcmd}},
    {ClkClientWin, MODKEY, Button1, movemouse, {0}},
    {ClkClientWin, Mod1Mask, Button1, resizemouse, {0}},
    {ClkClientWin, MODKEY, Button2, togglefloating, {0}},
    {ClkClientWin, MODKEY, Button3, resizemouse, {0}},
    {ClkTagBar, 0, Button1, view, {0}},
    {ClkTagBar, 0, Button3, toggleview, {0}},
    {ClkTagBar, MODKEY, Button1, tag, {0}},
    {ClkTagBar, MODKEY, Button3, toggletag, {0}},
 };
--- a/config.mk
+++ b/config.mk
@ -1,5 +1,5 @@
 # dwm version
-VERSION = 6.6
+VERSION = 6.8
 # Customize below to fit your system
--- a/drw.c
+++ b/drw.c
@ -178,8 +178,7 @@ drw_clr_create(Drw *drw, Clr *dest, const char *clrname)
 		die("error, cannot allocate color '%s'", clrname);
 }
-/* Wrapper to create color schemes. The caller has to call free(3) on the
+/* Create color schemes. */
 * returned color scheme when done using it. */
 Clr *
 drw_scm_create(Drw *drw, const char *clrnames[], size_t clrcount)
 {
@ -187,7 +186,7 @@ drw_scm_create(Drw *drw, const char *clrnames[], size_t clrcount)
 	Clr *ret;
 	/* need at least two colors for a scheme */
-	if (!drw || !clrnames || clrcount < 2 || !(ret = ecalloc(clrcount, sizeof(XftColor))))
+	if (!drw || !clrnames || clrcount < 2 || !(ret = ecalloc(clrcount, sizeof(Clr))))
 		return NULL;
 	for (i = 0; i < clrcount; i++)
@ -195,6 +194,30 @@ drw_scm_create(Drw *drw, const char *clrnames[], size_t clrcount)
 	return ret;
 }
 void
 drw_clr_free(Drw *drw, Clr *c)
 {
 	if (!drw || !c)
 		return;
 	/* c is typedef XftColor Clr */
 	XftColorFree(drw->dpy, DefaultVisual(drw->dpy, drw->screen),
 	             DefaultColormap(drw->dpy, drw->screen), c);
 }
 void
 drw_scm_free(Drw *drw, Clr *scm, size_t clrcount)
 {
 	size_t i;
 	if (!drw || !scm)
 		return;
 	for (i = 0; i < clrcount; i++)
 		drw_clr_free(drw, &scm[i]);
 	free(scm);
 }
 void
 drw_setfontset(Drw *drw, Fnt *set)
 {
--- a/drw.h
+++ b/drw.h
@ -40,7 +40,9 @@ void drw_font_getexts(Fnt *font, const char *text, unsigned int len, unsigned in
 /* Colorscheme abstraction */
 void drw_clr_create(Drw *drw, Clr *dest, const char *clrname);
 void drw_clr_free(Drw *drw, Clr *c);
 Clr *drw_scm_create(Drw *drw, const char *clrnames[], size_t clrcount);
 void drw_scm_free(Drw *drw, Clr *scm, size_t clrcount);
 /* Cursor abstraction */
 Cur *drw_cur_create(Drw *drw, int shape);
--- a/drw.o
+++ b/drw.o
--- a/BIN
+++ b/BIN
--- a/dwm.1
+++ b/dwm.1
@ -30,6 +30,14 @@ top left corner.  The tags which are applied to one or more windows are
 indicated with an empty square in the top left corner.
 .P
 dwm draws a small border around windows to indicate the focus state.
 .P
 On start, dwm can start additional programs that may be specified in two special
 shell scripts (see the FILES section below), autostart_blocking.sh and
 autostart.sh.  The former is executed first and dwm will wait for its
 termination before starting.  The latter is executed in the background before
 dwm enters its handler loop.
 .P
 Either of these files may be omitted.
 .SH OPTIONS
 .TP
 .B \-v
@ -152,6 +160,21 @@ Toggles focused window between floating and tiled state.
 .TP
 .B Mod1\-Button3
 Resize focused window while dragging. Tiled windows will be toggled to the floating state.
 .SH FILES
 The files containing programs to be started along with dwm are searched for in
 the following directories:
 .IP "1. $XDG_DATA_HOME/dwm"
 .IP "2. $HOME/.local/share/dwm"
 .IP "3. $HOME/.dwm"
 .P
 The first existing directory is scanned for any of the autostart files below.
 .TP 15
 autostart.sh
 This file is started as a shell background process before dwm enters its handler
 loop.
 .TP 15
 autostart_blocking.sh
 This file is started before any autostart.sh; dwm waits for its termination.
 .SH CUSTOMIZATION
 dwm is customized by creating a custom config.h and (re)compiling the source
 code. This keeps it fast, secure and simple.
--- a/dwm.c
+++ b/dwm.c
--- a/dwm.o
+++ b/dwm.o
--- a/util.o
+++ b/util.o
--- a/vanitygaps.c
+++ b/vanitygaps.c
@ -0,0 +1,822 @@
 /* Key binding functions */
 static void defaultgaps(const Arg *arg);
 static void incrgaps(const Arg *arg);
 static void incrigaps(const Arg *arg);
 static void incrogaps(const Arg *arg);
 static void incrohgaps(const Arg *arg);
 static void incrovgaps(const Arg *arg);
 static void incrihgaps(const Arg *arg);
 static void incrivgaps(const Arg *arg);
 static void togglegaps(const Arg *arg);
 /* Layouts (delete the ones you do not need) */
 static void bstack(Monitor *m);
 static void bstackhoriz(Monitor *m);
 static void centeredmaster(Monitor *m);
 static void centeredfloatingmaster(Monitor *m);
 static void deck(Monitor *m);
 static void dwindle(Monitor *m);
 static void fibonacci(Monitor *m, int s);
 static void grid(Monitor *m);
 static void nrowgrid(Monitor *m);
 static void spiral(Monitor *m);
 static void tile(Monitor *m);
 /* Internals */
 static void getgaps(Monitor *m, int *oh, int *ov, int *ih, int *iv, unsigned int *nc);
 static void getfacts(Monitor *m, int msize, int ssize, float *mf, float *sf, int *mr, int *sr);
 static void setgaps(int oh, int ov, int ih, int iv);
 /* Settings */
 #if !PERTAG_PATCH
 static int enablegaps = 1;
 #endif // PERTAG_PATCH
 void
 setgaps(int oh, int ov, int ih, int iv)
 {
 	if (oh < 0) oh = 0;
 	if (ov < 0) ov = 0;
 	if (ih < 0) ih = 0;
 	if (iv < 0) iv = 0;
 	selmon->gappoh = oh;
 	selmon->gappov = ov;
 	selmon->gappih = ih;
 	selmon->gappiv = iv;
 	arrange(selmon);
 }
 void
 togglegaps(const Arg *arg)
 {
 	#if PERTAG_PATCH
 	selmon->pertag->enablegaps[selmon->pertag->curtag] = !selmon->pertag->enablegaps[selmon->pertag->curtag];
 	#else
 	enablegaps = !enablegaps;
 	#endif // PERTAG_PATCH
 	arrange(NULL);
 }
 void
 defaultgaps(const Arg *arg)
 {
 	setgaps(gappoh, gappov, gappih, gappiv);
 }
 void
 incrgaps(const Arg *arg)
 {
 	setgaps(
 		selmon->gappoh + arg->i,
 		selmon->gappov + arg->i,
 		selmon->gappih + arg->i,
 		selmon->gappiv + arg->i
 	);
 }
 void
 incrigaps(const Arg *arg)
 {
 	setgaps(
 		selmon->gappoh,
 		selmon->gappov,
 		selmon->gappih + arg->i,
 		selmon->gappiv + arg->i
 	);
 }
 void
 incrogaps(const Arg *arg)
 {
 	setgaps(
 		selmon->gappoh + arg->i,
 		selmon->gappov + arg->i,
 		selmon->gappih,
 		selmon->gappiv
 	);
 }
 void
 incrohgaps(const Arg *arg)
 {
 	setgaps(
 		selmon->gappoh + arg->i,
 		selmon->gappov,
 		selmon->gappih,
 		selmon->gappiv
 	);
 }
 void
 incrovgaps(const Arg *arg)
 {
 	setgaps(
 		selmon->gappoh,
 		selmon->gappov + arg->i,
 		selmon->gappih,
 		selmon->gappiv
 	);
 }
 void
 incrihgaps(const Arg *arg)
 {
 	setgaps(
 		selmon->gappoh,
 		selmon->gappov,
 		selmon->gappih + arg->i,
 		selmon->gappiv
 	);
 }
 void
 incrivgaps(const Arg *arg)
 {
 	setgaps(
 		selmon->gappoh,
 		selmon->gappov,
 		selmon->gappih,
 		selmon->gappiv + arg->i
 	);
 }
 void
 getgaps(Monitor *m, int *oh, int *ov, int *ih, int *iv, unsigned int *nc)
 {
 	unsigned int n, oe, ie;
 	#if PERTAG_PATCH
 	oe = ie = selmon->pertag->enablegaps[selmon->pertag->curtag];
 	#else
 	oe = ie = enablegaps;
 	#endif // PERTAG_PATCH
 	Client *c;
 	for (n = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), n++);
 	if (smartgaps && n == 1) {
 		oe = 0; // outer gaps disabled when only one client
 	}
 	*oh = m->gappoh*oe; // outer horizontal gap
 	*ov = m->gappov*oe; // outer vertical gap
 	*ih = m->gappih*ie; // inner horizontal gap
 	*iv = m->gappiv*ie; // inner vertical gap
 	*nc = n;            // number of clients
 }
 void
 getfacts(Monitor *m, int msize, int ssize, float *mf, float *sf, int *mr, int *sr)
 {
 	unsigned int n;
 	float mfacts = 0, sfacts = 0;
 	int mtotal = 0, stotal = 0;
 	Client *c;
 	for (n = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), n++)
 		if (n < m->nmaster)
 			mfacts += c->cfact;
 		else
 			sfacts += c->cfact;
 	for (n = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), n++)
 		if (n < m->nmaster)
 			mtotal += msize * (c->cfact / mfacts);
 		else
 			stotal += ssize * (c->cfact / sfacts);
 	*mf = mfacts; // total factor of master area
 	*sf = sfacts; // total factor of stack area
 	*mr = msize - mtotal; // the remainder (rest) of pixels after a cfacts master split
 	*sr = ssize - stotal; // the remainder (rest) of pixels after a cfacts stack split
 }
 /***
 * Layouts
 */
 /*
 * Bottomstack layout + gaps
 * https://dwm.suckless.org/patches/bottomstack/
 */
 static void
 bstack(Monitor *m)
 {
 	unsigned int i, n;
 	int oh, ov, ih, iv;
 	int mx = 0, my = 0, mh = 0, mw = 0;
 	int sx = 0, sy = 0, sh = 0, sw = 0;
 	float mfacts, sfacts;
 	int mrest, srest;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	sx = mx = m->wx + ov;
 	sy = my = m->wy + oh;
 	sh = mh = m->wh - 2*oh;
 	mw = m->ww - 2*ov - iv * (MIN(n, m->nmaster) - 1);
 	sw = m->ww - 2*ov - iv * (n - m->nmaster - 1);
 	if (m->nmaster && n > m->nmaster) {
 		sh = (mh - ih) * (1 - m->mfact);
 		mh = mh - ih - sh;
 		sx = mx;
 		sy = my + mh + ih;
 	}
 	getfacts(m, mw, sw, &mfacts, &sfacts, &mrest, &srest);
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++) {
 		if (i < m->nmaster) {
 			resize(c, mx, my, mw * (c->cfact / mfacts) + (i < mrest ? 1 : 0) - (2*c->bw), mh - (2*c->bw), 0);
 			mx += WIDTH(c) + iv;
 		} else {
 			resize(c, sx, sy, sw * (c->cfact / sfacts) + ((i - m->nmaster) < srest ? 1 : 0) - (2*c->bw), sh - (2*c->bw), 0);
 			sx += WIDTH(c) + iv;
 		}
 	}
 }
 static void
 bstackhoriz(Monitor *m)
 {
 	unsigned int i, n;
 	int oh, ov, ih, iv;
 	int mx = 0, my = 0, mh = 0, mw = 0;
 	int sx = 0, sy = 0, sh = 0, sw = 0;
 	float mfacts, sfacts;
 	int mrest, srest;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	sx = mx = m->wx + ov;
 	sy = my = m->wy + oh;
 	mh = m->wh - 2*oh;
 	sh = m->wh - 2*oh - ih * (n - m->nmaster - 1);
 	mw = m->ww - 2*ov - iv * (MIN(n, m->nmaster) - 1);
 	sw = m->ww - 2*ov;
 	if (m->nmaster && n > m->nmaster) {
 		sh = (mh - ih) * (1 - m->mfact);
 		mh = mh - ih - sh;
 		sy = my + mh + ih;
 		sh = m->wh - mh - 2*oh - ih * (n - m->nmaster);
 	}
 	getfacts(m, mw, sh, &mfacts, &sfacts, &mrest, &srest);
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++) {
 		if (i < m->nmaster) {
 			resize(c, mx, my, mw * (c->cfact / mfacts) + (i < mrest ? 1 : 0) - (2*c->bw), mh - (2*c->bw), 0);
 			mx += WIDTH(c) + iv;
 		} else {
 			resize(c, sx, sy, sw - (2*c->bw), sh * (c->cfact / sfacts) + ((i - m->nmaster) < srest ? 1 : 0) - (2*c->bw), 0);
 			sy += HEIGHT(c) + ih;
 		}
 	}
 }
 /*
 * Centred master layout + gaps
 * https://dwm.suckless.org/patches/centeredmaster/
 */
 void
 centeredmaster(Monitor *m)
 {
 	unsigned int i, n;
 	int oh, ov, ih, iv;
 	int mx = 0, my = 0, mh = 0, mw = 0;
 	int lx = 0, ly = 0, lw = 0, lh = 0;
 	int rx = 0, ry = 0, rw = 0, rh = 0;
 	float mfacts = 0, lfacts = 0, rfacts = 0;
 	int mtotal = 0, ltotal = 0, rtotal = 0;
 	int mrest = 0, lrest = 0, rrest = 0;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	/* initialize areas */
 	mx = m->wx + ov;
 	my = m->wy + oh;
 	mh = m->wh - 2*oh - ih * ((!m->nmaster ? n : MIN(n, m->nmaster)) - 1);
 	mw = m->ww - 2*ov;
 	lh = m->wh - 2*oh - ih * (((n - m->nmaster) / 2) - 1);
 	rh = m->wh - 2*oh - ih * (((n - m->nmaster) / 2) - ((n - m->nmaster) % 2 ? 0 : 1));
 	if (m->nmaster && n > m->nmaster) {
 		/* go mfact box in the center if more than nmaster clients */
 		if (n - m->nmaster > 1) {
 			/* ||<-S->|<---M--->|<-S->|| */
 			mw = (m->ww - 2*ov - 2*iv) * m->mfact;
 			lw = (m->ww - mw - 2*ov - 2*iv) / 2;
 			rw = (m->ww - mw - 2*ov - 2*iv) - lw;
 			mx += lw + iv;
 		} else {
 			/* ||<---M--->|<-S->|| */
 			mw = (mw - iv) * m->mfact;
 			lw = 0;
 			rw = m->ww - mw - iv - 2*ov;
 		}
 		lx = m->wx + ov;
 		ly = m->wy + oh;
 		rx = mx + mw + iv;
 		ry = m->wy + oh;
 	}
 	/* calculate facts */
 	for (n = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), n++) {
 		if (!m->nmaster || n < m->nmaster)
 			mfacts += c->cfact;
 		else if ((n - m->nmaster) % 2)
 			lfacts += c->cfact; // total factor of left hand stack area
 		else
 			rfacts += c->cfact; // total factor of right hand stack area
 	}
 	for (n = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), n++)
 		if (!m->nmaster || n < m->nmaster)
 			mtotal += mh * (c->cfact / mfacts);
 		else if ((n - m->nmaster) % 2)
 			ltotal += lh * (c->cfact / lfacts);
 		else
 			rtotal += rh * (c->cfact / rfacts);
 	mrest = mh - mtotal;
 	lrest = lh - ltotal;
 	rrest = rh - rtotal;
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++) {
 		if (!m->nmaster || i < m->nmaster) {
 			/* nmaster clients are stacked vertically, in the center of the screen */
 			resize(c, mx, my, mw - (2*c->bw), mh * (c->cfact / mfacts) + (i < mrest ? 1 : 0) - (2*c->bw), 0);
 			my += HEIGHT(c) + ih;
 		} else {
 			/* stack clients are stacked vertically */
 			if ((i - m->nmaster) % 2 ) {
 				resize(c, lx, ly, lw - (2*c->bw), lh * (c->cfact / lfacts) + ((i - 2*m->nmaster) < 2*lrest ? 1 : 0) - (2*c->bw), 0);
 				ly += HEIGHT(c) + ih;
 			} else {
 				resize(c, rx, ry, rw - (2*c->bw), rh * (c->cfact / rfacts) + ((i - 2*m->nmaster) < 2*rrest ? 1 : 0) - (2*c->bw), 0);
 				ry += HEIGHT(c) + ih;
 			}
 		}
 	}
 }
 void
 centeredfloatingmaster(Monitor *m)
 {
 	unsigned int i, n;
 	float mfacts, sfacts;
 	float mivf = 1.0; // master inner vertical gap factor
 	int oh, ov, ih, iv, mrest, srest;
 	int mx = 0, my = 0, mh = 0, mw = 0;
 	int sx = 0, sy = 0, sh = 0, sw = 0;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	sx = mx = m->wx + ov;
 	sy = my = m->wy + oh;
 	sh = mh = m->wh - 2*oh;
 	mw = m->ww - 2*ov - iv*(n - 1);
 	sw = m->ww - 2*ov - iv*(n - m->nmaster - 1);
 	if (m->nmaster && n > m->nmaster) {
 		mivf = 0.8;
 		/* go mfact box in the center if more than nmaster clients */
 		if (m->ww > m->wh) {
 			mw = m->ww * m->mfact - iv*mivf*(MIN(n, m->nmaster) - 1);
 			mh = m->wh * 0.9;
 		} else {
 			mw = m->ww * 0.9 - iv*mivf*(MIN(n, m->nmaster) - 1);
 			mh = m->wh * m->mfact;
 		}
 		mx = m->wx + (m->ww - mw) / 2;
 		my = m->wy + (m->wh - mh - 2*oh) / 2;
 		sx = m->wx + ov;
 		sy = m->wy + oh;
 		sh = m->wh - 2*oh;
 	}
 	getfacts(m, mw, sw, &mfacts, &sfacts, &mrest, &srest);
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++)
 		if (i < m->nmaster) {
 			/* nmaster clients are stacked horizontally, in the center of the screen */
 			resize(c, mx, my, mw * (c->cfact / mfacts) + (i < mrest ? 1 : 0) - (2*c->bw), mh - (2*c->bw), 0);
 			mx += WIDTH(c) + iv*mivf;
 		} else {
 			/* stack clients are stacked horizontally */
 			resize(c, sx, sy, sw * (c->cfact / sfacts) + ((i - m->nmaster) < srest ? 1 : 0) - (2*c->bw), sh - (2*c->bw), 0);
 			sx += WIDTH(c) + iv;
 		}
 }
 /*
 * Deck layout + gaps
 * https://dwm.suckless.org/patches/deck/
 */
 void
 deck(Monitor *m)
 {
 	unsigned int i, n;
 	int oh, ov, ih, iv;
 	int mx = 0, my = 0, mh = 0, mw = 0;
 	int sx = 0, sy = 0, sh = 0, sw = 0;
 	float mfacts, sfacts;
 	int mrest, srest;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	sx = mx = m->wx + ov;
 	sy = my = m->wy + oh;
 	sh = mh = m->wh - 2*oh - ih * (MIN(n, m->nmaster) - 1);
 	sw = mw = m->ww - 2*ov;
 	if (m->nmaster && n > m->nmaster) {
 		sw = (mw - iv) * (1 - m->mfact);
 		mw = mw - iv - sw;
 		sx = mx + mw + iv;
 		sh = m->wh - 2*oh;
 	}
 	getfacts(m, mh, sh, &mfacts, &sfacts, &mrest, &srest);
 	if (n - m->nmaster > 0) /* override layout symbol */
 		snprintf(m->ltsymbol, sizeof m->ltsymbol, "D %d", n - m->nmaster);
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++)
 		if (i < m->nmaster) {
 			resize(c, mx, my, mw - (2*c->bw), mh * (c->cfact / mfacts) + (i < mrest ? 1 : 0) - (2*c->bw), 0);
 			my += HEIGHT(c) + ih;
 		} else {
 			resize(c, sx, sy, sw - (2*c->bw), sh - (2*c->bw), 0);
 		}
 }
 /*
 * Fibonacci layout + gaps
 * https://dwm.suckless.org/patches/fibonacci/
 */
 void
 fibonacci(Monitor *m, int s)
 {
 	unsigned int i, n;
 	int nx, ny, nw, nh;
 	int oh, ov, ih, iv;
 	int nv, hrest = 0, wrest = 0, r = 1;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	nx = m->wx + ov;
 	ny = m->wy + oh;
 	nw = m->ww - 2*ov;
 	nh = m->wh - 2*oh;
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next)) {
 		if (r) {
 			if ((i % 2 && (nh - ih) / 2 <= (bh + 2*c->bw))
 			   || (!(i % 2) && (nw - iv) / 2 <= (bh + 2*c->bw))) {
 				r = 0;
 			}
 			if (r && i < n - 1) {
 				if (i % 2) {
 					nv = (nh - ih) / 2;
 					hrest = nh - 2*nv - ih;
 					nh = nv;
 				} else {
 					nv = (nw - iv) / 2;
 					wrest = nw - 2*nv - iv;
 					nw = nv;
 				}
 				if ((i % 4) == 2 && !s)
 					nx += nw + iv;
 				else if ((i % 4) == 3 && !s)
 					ny += nh + ih;
 			}
 			if ((i % 4) == 0) {
 				if (s) {
 					ny += nh + ih;
 					nh += hrest;
 				}
 				else {
 					nh -= hrest;
 					ny -= nh + ih;
 				}
 			}
 			else if ((i % 4) == 1) {
 				nx += nw + iv;
 				nw += wrest;
 			}
 			else if ((i % 4) == 2) {
 				ny += nh + ih;
 				nh += hrest;
 				if (i < n - 1)
 					nw += wrest;
 			}
 			else if ((i % 4) == 3) {
 				if (s) {
 					nx += nw + iv;
 					nw -= wrest;
 				} else {
 					nw -= wrest;
 					nx -= nw + iv;
 					nh += hrest;
 				}
 			}
 			if (i == 0)	{
 				if (n != 1) {
 					nw = (m->ww - iv - 2*ov) - (m->ww - iv - 2*ov) * (1 - m->mfact);
 					wrest = 0;
 				}
 				ny = m->wy + oh;
 			}
 			else if (i == 1)
 				nw = m->ww - nw - iv - 2*ov;
 			i++;
 		}
 		resize(c, nx, ny, nw - (2*c->bw), nh - (2*c->bw), False);
 	}
 }
 void
 dwindle(Monitor *m)
 {
 	fibonacci(m, 1);
 }
 void
 spiral(Monitor *m)
 {
 	fibonacci(m, 0);
 }
 /*
 * Gappless grid layout + gaps (ironically)
 * https://dwm.suckless.org/patches/gaplessgrid/
 */
 void
 gaplessgrid(Monitor *m)
 {
 	unsigned int i, n;
 	int x, y, cols, rows, ch, cw, cn, rn, rrest, crest; // counters
 	int oh, ov, ih, iv;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	/* grid dimensions */
 	for (cols = 0; cols <= n/2; cols++)
 		if (cols*cols >= n)
 			break;
 	if (n == 5) /* set layout against the general calculation: not 1:2:2, but 2:3 */
 		cols = 2;
 	rows = n/cols;
 	cn = rn = 0; // reset column no, row no, client count
 	ch = (m->wh - 2*oh - ih * (rows - 1)) / rows;
 	cw = (m->ww - 2*ov - iv * (cols - 1)) / cols;
 	rrest = (m->wh - 2*oh - ih * (rows - 1)) - ch * rows;
 	crest = (m->ww - 2*ov - iv * (cols - 1)) - cw * cols;
 	x = m->wx + ov;
 	y = m->wy + oh;
 	for (i = 0, c = nexttiled(m->clients); c; i++, c = nexttiled(c->next)) {
 		if (i/rows + 1 > cols - n%cols) {
 			rows = n/cols + 1;
 			ch = (m->wh - 2*oh - ih * (rows - 1)) / rows;
 			rrest = (m->wh - 2*oh - ih * (rows - 1)) - ch * rows;
 		}
 		resize(c,
 			x,
 			y + rn*(ch + ih) + MIN(rn, rrest),
 			cw + (cn < crest ? 1 : 0) - 2*c->bw,
 			ch + (rn < rrest ? 1 : 0) - 2*c->bw,
 			0);
 		rn++;
 		if (rn >= rows) {
 			rn = 0;
 			x += cw + ih + (cn < crest ? 1 : 0);
 			cn++;
 		}
 	}
 }
 /*
 * Gridmode layout + gaps
 * https://dwm.suckless.org/patches/gridmode/
 */
 void
 grid(Monitor *m)
 {
 	unsigned int i, n;
 	int cx, cy, cw, ch, cc, cr, chrest, cwrest, cols, rows;
 	int oh, ov, ih, iv;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	/* grid dimensions */
 	for (rows = 0; rows <= n/2; rows++)
 		if (rows*rows >= n)
 			break;
 	cols = (rows && (rows - 1) * rows >= n) ? rows - 1 : rows;
 	/* window geoms (cell height/width) */
 	ch = (m->wh - 2*oh - ih * (rows - 1)) / (rows ? rows : 1);
 	cw = (m->ww - 2*ov - iv * (cols - 1)) / (cols ? cols : 1);
 	chrest = (m->wh - 2*oh - ih * (rows - 1)) - ch * rows;
 	cwrest = (m->ww - 2*ov - iv * (cols - 1)) - cw * cols;
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++) {
 		cc = i / rows;
 		cr = i % rows;
 		cx = m->wx + ov + cc * (cw + iv) + MIN(cc, cwrest);
 		cy = m->wy + oh + cr * (ch + ih) + MIN(cr, chrest);
 		resize(c, cx, cy, cw + (cc < cwrest ? 1 : 0) - 2*c->bw, ch + (cr < chrest ? 1 : 0) - 2*c->bw, False);
 	}
 }
 /*
 * Horizontal grid layout + gaps
 * https://dwm.suckless.org/patches/horizgrid/
 */
 void
 horizgrid(Monitor *m) {
 	Client *c;
 	unsigned int n, i;
 	int oh, ov, ih, iv;
 	int mx = 0, my = 0, mh = 0, mw = 0;
 	int sx = 0, sy = 0, sh = 0, sw = 0;
 	int ntop, nbottom = 1;
 	float mfacts = 0, sfacts = 0;
 	int mrest, srest, mtotal = 0, stotal = 0;
 	/* Count windows */
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	if (n <= 2)
 		ntop = n;
 	else {
 		ntop = n / 2;
 		nbottom = n - ntop;
 	}
 	sx = mx = m->wx + ov;
 	sy = my = m->wy + oh;
 	sh = mh = m->wh - 2*oh;
 	sw = mw = m->ww - 2*ov;
 	if (n > ntop) {
 		sh = (mh - ih) / 2;
 		mh = mh - ih - sh;
 		sy = my + mh + ih;
 		mw = m->ww - 2*ov - iv * (ntop - 1);
 		sw = m->ww - 2*ov - iv * (nbottom - 1);
 	}
 	/* calculate facts */
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++)
 		if (i < ntop)
 			mfacts += c->cfact;
 		else
 			sfacts += c->cfact;
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++)
 		if (i < ntop)
 			mtotal += mh * (c->cfact / mfacts);
 		else
 			stotal += sw * (c->cfact / sfacts);
 	mrest = mh - mtotal;
 	srest = sw - stotal;
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++)
 		if (i < ntop) {
 			resize(c, mx, my, mw * (c->cfact / mfacts) + (i < mrest ? 1 : 0) - (2*c->bw), mh - (2*c->bw), 0);
 			mx += WIDTH(c) + iv;
 		} else {
 			resize(c, sx, sy, sw * (c->cfact / sfacts) + ((i - ntop) < srest ? 1 : 0) - (2*c->bw), sh - (2*c->bw), 0);
 			sx += WIDTH(c) + iv;
 		}
 }
 /*
 * nrowgrid layout + gaps
 * https://dwm.suckless.org/patches/nrowgrid/
 */
 void
 nrowgrid(Monitor *m)
 {
 	unsigned int n;
 	int ri = 0, ci = 0;  /* counters */
 	int oh, ov, ih, iv;                         /* vanitygap settings */
 	unsigned int cx, cy, cw, ch;                /* client geometry */
 	unsigned int uw = 0, uh = 0, uc = 0;        /* utilization trackers */
 	unsigned int cols, rows = m->nmaster + 1;
 	Client *c;
 	/* count clients */
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	/* nothing to do here */
 	if (n == 0)
 		return;
 	/* force 2 clients to always split vertically */
 	if (FORCE_VSPLIT && n == 2)
 		rows = 1;
 	/* never allow empty rows */
 	if (n < rows)
 		rows = n;
 	/* define first row */
 	cols = n / rows;
 	uc = cols;
 	cy = m->wy + oh;
 	ch = (m->wh - 2*oh - ih*(rows - 1)) / rows;
 	uh = ch;
 	for (c = nexttiled(m->clients); c; c = nexttiled(c->next), ci++) {
 		if (ci == cols) {
 			uw = 0;
 			ci = 0;
 			ri++;
 			/* next row */
 			cols = (n - uc) / (rows - ri);
 			uc += cols;
 			cy = m->wy + oh + uh + ih;
 			uh += ch + ih;
 		}
 		cx = m->wx + ov + uw;
 		cw = (m->ww - 2*ov - uw) / (cols - ci);
 		uw += cw + iv;
 		resize(c, cx, cy, cw - (2*c->bw), ch - (2*c->bw), 0);
 	}
 }
 /*
 * Default tile layout + gaps
 */
 static void
 tile(Monitor *m)
 {
 	unsigned int i, n;
 	int oh, ov, ih, iv;
 	int mx = 0, my = 0, mh = 0, mw = 0;
 	int sx = 0, sy = 0, sh = 0, sw = 0;
 	float mfacts, sfacts;
 	int mrest, srest;
 	Client *c;
 	getgaps(m, &oh, &ov, &ih, &iv, &n);
 	if (n == 0)
 		return;
 	sx = mx = m->wx + ov;
 	sy = my = m->wy + oh;
 	mh = m->wh - 2*oh - ih * (MIN(n, m->nmaster) - 1);
 	sh = m->wh - 2*oh - ih * (n - m->nmaster - 1);
 	sw = mw = m->ww - 2*ov;
 	if (m->nmaster && n > m->nmaster) {
 		sw = (mw - iv) * (1 - m->mfact);
 		mw = mw - iv - sw;
 		sx = mx + mw + iv;
 	}
 	getfacts(m, mh, sh, &mfacts, &sfacts, &mrest, &srest);
 	for (i = 0, c = nexttiled(m->clients); c; c = nexttiled(c->next), i++)
 		if (i < m->nmaster) {
 			resize(c, mx, my, mw - (2*c->bw), mh * (c->cfact / mfacts) + (i < mrest ? 1 : 0) - (2*c->bw), 0);
 			my += HEIGHT(c) + ih;
 		} else {
 			resize(c, sx, sy, sw - (2*c->bw), sh * (c->cfact / sfacts) + ((i - m->nmaster) < srest ? 1 : 0) - (2*c->bw), 0);
 			sy += HEIGHT(c) + ih;
 		}
 }
Author	SHA1	Message	Date
lucy	242e653ecf	add patched defaults	2026-02-26 11:53:01 +01:00
NRK	c3dd6a829b	more overflow fix in getatomprop() commit 244fa852 (and a9aa0d8) tried to fix overflow by checking the number of items returned. however this is not sufficient since the format may be lower than 32 bits. to reproduce the crash, i used the reproducer given in commit 244fa85 but changed the XChangeProperty line to the following to set the property to a 1 element 16 bit item: short si = 1; XChangeProperty(d, w, net_wm_state, XA_ATOM, 16, PropModeReplace, (unsigned char *)&si, 1); this client reliably crashes dwm under ASAN since dwm is trying to read a 32 bit value from a 16 bit one. fix it by checking for format == 32 as well. also change the access type from Atom to long, on my machine Atom is typedef-ed to long already but that may not be true everywere. the XGetWindowProperty manpage says format == 32 is returned as `long` so use `long` directly. (N.B: it also might be worth checking if the returned type is XA_ATOM as well, but i wasn't able to cause any crashes by setting different types so i'm leaving it out for now.)	2026-02-20 15:31:29 +01:00
NRK	5c9f30300b	getstate: fix access type and remove redundant cast WM_STATE is defined to be format == 32 which xlib returns as `long` and so accessing it as `unsigned char` is incorrect. and also &p is already an `unsigned char *` and so the cast was completely redundant. given the redundant cast, i assume `p` was `long ` at some time but was changed to `unsigned char *` later, but the pointer access (and the cast) wasn't updated. also add a `format == 32` check as safety measure before accessing, just in case.	2026-02-20 15:31:28 +01:00
NRK	397d618f1c	fix not updating _NET_ACTIVE_WINDOW currently clients that set the input field of WM_HINTS to true (c->neverfocus) will never be updated as _NET_ACTIVE_WINDOW even when they are focused. according to the ICCCM [0] the input field of WM_HINTS tells the WM to either use or not use XSetInputFocus(), it shouldn't have any relation to _NET_ACTIVE_WINDOW. EWMH spec [1] also does not mention any relationship between the two. this issue was noticed when launching games via steam/proton and noticing that _NET_ACTIVE_WINDOW was always wrong/stale (i.e not updated to the game window). for reference I've looked at bspwm [2] and it also seems to set _NET_ACTIVE_WINDOW regardless of whether the client has WM_HINTS input true or not. [0]: https://x.org/releases/X11R7.6/doc/xorg-docs/specs/ICCCM/icccm.html#input_focus [1]: https://specifications.freedesktop.org/wm/1.5/ar01s03.html#id-1.4.10 [2]: `c5cf7d3943/src/tree.c (L659-L662)`	2026-02-13 10:16:08 +01:00
Hiltjo Posthuma	f63cde9354	bump version to 6.8	2026-01-30 11:18:38 +01:00
Chris Down	a9aa0d8ffb	dwm: Fix getatomprop regression from heap overflow fix Commit 244fa852fe27 ("dwm: Fix heap buffer overflow in getatomprop") introduced a check for dl > 0 before dereferencing the property pointer. However, I missed that the variable dl is passed to XGetWindowProperty for both nitems_return and bytes_after_return parameters: XGetWindowProperty(..., &dl, &dl, &p) The final value in dl is bytes_after_return, not nitems_return. For a successfully read property, bytes_after is typically 0 (indicating all data was retrieved), so the check `dl > 0` is always false and dwm never reads any atom properties. So this is safe, but not very helpful :-) dl is probably just a dummy variable anyway, so fix by using a separate variable for nitems, and check nitems > 0 as originally intended.	2026-01-16 14:13:51 +01:00
Hiltjo Posthuma	85fe518c1a	bump version to 6.7 Put the maintainer at the top and bump years (time flies).	2026-01-10 11:31:44 +01:00
Chris Down	244fa852fe	dwm: Fix heap buffer overflow in getatomprop When getatomprop() is called, it invokes XGetWindowProperty() to retrieve an Atom. If the property exists but has zero elements (length 0), Xlib returns Success and sets p to a valid, non-NULL memory address containing a single null byte. However, dl (that is, the number of items) is 0. dwm blindly casts p to Atom* and dereferences it. While Xlib guarantees that p is safe to read as a string (that is, it is null-terminated), it does _not_ guarantee it is safe to read as an Atom (an unsigned long). The Atom type is a typedef for unsigned long. Reading an Atom (which thus will either likely be 4 or 8 bytes) from a 1-byte allocated buffer results in a heap buffer overflow. Since property content is user controlled, this allows any client to trigger an out of bounds read simply by setting a property with format 32 and length 0. An example client which reliably crashes dwm under ASAN: #include <X11/Xlib.h> #include <X11/Xatom.h> #include <stdio.h> #include <stdlib.h> #include <unistd.h> int main(void) { Display *d; Window root, w; Atom net_wm_state; d = XOpenDisplay(NULL); if (!d) return 1; root = DefaultRootWindow(d); w = XCreateSimpleWindow(d, root, 10, 10, 200, 200, 1, 0, 0); net_wm_state = XInternAtom(d, "_NET_WM_STATE", False); if (net_wm_state == None) return 1; XChangeProperty(d, w, net_wm_state, XA_ATOM, 32, PropModeReplace, NULL, 0); XMapWindow(d, w); XSync(d, False); sleep(1); XCloseDisplay(d); return 0; } In order to avoid this, check that the number of items returned is greater than zero before dereferencing the pointer.	2026-01-10 11:27:23 +01:00
Hiltjo Posthuma	7c3abae4e6	drw.c: drw_scm_free: call free inside Because drw_scm_create() allocates it.	2025-09-29 18:48:27 +02:00
Hiltjo Posthuma	93f26863d1	cleanup schemes and colors	2025-09-27 12:10:17 +02:00